Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extension Json to make way for changes on extensions page and environments page #3923

Closed
wants to merge 11 commits into from

Conversation

bbonaby
Copy link
Contributor

@bbonaby bbonaby commented Oct 3, 2024

Summary of the pull request

This change is the first change to allow us to provide more information to users about extension that are not already installed in Dev Home. See issue #3911 for more details or see the spec I sent out to DevHomeAll for even more info on what's to come (or ping me for the link). Most of the change is just the json files and their C# counter parts.

Changes:

  • Added a Json file called ExtensionInformation.json. This json file outlines information about currently known Dev Home extensions.
  • Use the WinGet service to get the package display name, publisher name and description for the package. In the future we can use WinGet to also get the icons for the package. Assuming they are checked into the WinGet catalog.
  • Added A Json schema file ExtensionInformation.schema.json so that the above json file can be validated against.
  • Added tests that should be runnable in the pipeline so changes to the ExtensionInformation.json adhere to the schema in ExtensionInformation.schema.json.
  • Added C# classes that the ExtensionInformation.json will be deserialized into so it can be used in code.
  • The ExtensionService now returns a DevHomeExtensionContentData which just contains the data from the json in C# classes/properties. This is used by the ExtensionLibraryViewModel to show the list of non-installed extensions in its "Available in the Microsoft Store` section

Here is a video showing me go to the extensions page to confirm functionality is not regressed:

recording.of.me.going.to.extensions.library.page.after.changes.mp4

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

Copy link
Contributor

@vineeththomasalex vineeththomasalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no blocking comments

src/Assets/ExtensionInformation.json Show resolved Hide resolved
src/Strings/en-us/Resources.resw Outdated Show resolved Hide resolved
Copy link
Collaborator

@krschau krschau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding check-ins for the moment.

@bbonaby
Copy link
Contributor Author

bbonaby commented Oct 14, 2024

Closing this PR and moving it and the future updates I had for it to a feature branch for the future team to continue: https://github.com/microsoft/devhome/tree/feature/devhome-extension-and-provider-discoverability-update. Reach out if you have any questions. Thanks.

@bbonaby bbonaby closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants