-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update extension Json to make way for changes on extensions page and environments page #3923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, no blocking comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holding check-ins for the moment.
Closing this PR and moving it and the future updates I had for it to a feature branch for the future team to continue: https://github.com/microsoft/devhome/tree/feature/devhome-extension-and-provider-discoverability-update. Reach out if you have any questions. Thanks. |
Summary of the pull request
This change is the first change to allow us to provide more information to users about extension that are not already installed in Dev Home. See issue #3911 for more details or see the spec I sent out to DevHomeAll for even more info on what's to come (or ping me for the link). Most of the change is just the json files and their C# counter parts.
Changes:
ExtensionInformation.json
. This json file outlines information about currently known Dev Home extensions.ExtensionInformation.schema.json
so that the above json file can be validated against.ExtensionInformation.json
adhere to the schema inExtensionInformation.schema.json
.ExtensionInformation.json
will be deserialized into so it can be used in code.DevHomeExtensionContentData
which just contains the data from the json in C# classes/properties. This is used by theExtensionLibraryViewModel
to show the list of non-installed extensions in its "Available in the Microsoft Store` sectionHere is a video showing me go to the extensions page to confirm functionality is not regressed:
recording.of.me.going.to.extensions.library.page.after.changes.mp4
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist